Karan Questionnaire bug fixes and code refinement #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 42.25% 42.39% +0.15%
==========================================
Files 45 45
Lines 2076 2069 -7
==========================================
Hits 877 877
+ Misses 1199 1192 -7
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questionnaire Bug Fixes
♻️ Current situation & Problem
There were different approaches to fix issues, and commented out code in the existing version, and a SpeziScheduler Issue. This PR focuses on fixing the following issue: StanfordSpezi/SpeziScheduler#36
⚙️ Release Notes
Bug Fixes:
Cleaning and Optimizing Code
Results:
📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
✅ Testing
No additional testing here, unit testing testing occurs in the PR in the SpeziScheduler repository, and it passes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: